Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1055#discussion_r13683400
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
 ---
    @@ -53,12 +51,15 @@ abstract class Expression extends TreeNode[Expression] {
     
       /**
        * Returns `true` if this expression and all its children have been 
resolved to a specific schema
    -   * and `false` if it is still contains any unresolved placeholders. 
Implementations of expressions
    +   * and `false` if it still contains any unresolved placeholders. 
Implementations of expressions
        * should override this if the resolution of this type of expression 
involves more than just
        * the resolution of its children.
        */
       lazy val resolved: Boolean = childrenResolved
     
    +  /** Generally, this is invalid to query if `resolved` is false. */
    --- End diff --
    
    How about:
    
    "Returns the [[DataType]] of the result of evaluating this expression.  It 
is invalid to query the `dataType` of an unresolved expression (i.e., when 
`resolved == false`)."


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to