Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/8109#issuecomment-130361068
> about your comment on ShutdownHookManager, should I rename it?
No, the name is fine. I was just giving some historical context.
> I've seen instances of calls to Runtime.getRuntime.addShutdownHook..
From a quick look, it seems that at least the one in `ExternalBlockStore`
should be changed; the other two seem to be separate processes (i.e. they are
not part of a Spark application) so that's questionable. But I'd say leave it
for a different change (maybe file a separate bug so it doesn't fall through
the cracks).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
