Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8126#discussion_r36908036
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/mllib/optimization/GradientDescent.scala 
---
    @@ -144,6 +145,21 @@ class GradientDescent private[spark] (private var 
gradient: Gradient, private va
      */
     @DeveloperApi
     object GradientDescent extends Logging {
    +  /** Java-friendly version of [[runMiniBatchSGD()]] */
    +  def runMiniBatchSGD(
    --- End diff --
    
    I don't think we need to make this Java-friendly.  It's a DeveloperApi, and 
I've never heard of Java users wanting to build algorithms off of our 
GradientDescent.  Could you remove this please?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to