Github user ericl commented on a diff in the pull request: https://github.com/apache/spark/pull/8143#discussion_r36924356 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/RFormula.scala --- @@ -144,6 +145,12 @@ class RFormulaModel private[feature]( pipelineModel: PipelineModel) extends Model[RFormulaModel] with RFormulaBase { + /** @group setParam */ --- End diff -- Does it make sense to have these setters for the Model? They will not take effect for transform() since the model is already fitted.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org