Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7957#discussion_r36938580
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala ---
    @@ -1135,17 +1135,18 @@ class DataFrame private[sql](
        * @group dfops
        * @since 1.3.0
        */
    -  def withColumn(colName: String, col: Column): DataFrame = {
    +  def withColumn(colName: String, col: Column, metadata: Option[Metadata] 
= None): DataFrame = {
    --- End diff --
    
    Can you do this in a different PR?  Also we should do it without using 
`Option` and default arguments so that it works well in Java.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to