Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/8062#discussion_r36940759
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/DecisionTreeClassifier.scala
---
@@ -144,7 +144,7 @@ final class DecisionTreeClassificationModel private[ml]
(
}
override def toString: String = {
- s"DecisionTreeClassificationModel of depth $depth with $numNodes nodes"
+ s"${super.toString} DecisionTreeClassificationModel of depth $depth
with $numNodes nodes"
--- End diff --
How about using `$uid` directly in `toString` implementation? It is not
guaranteed that `super.toString` contains the UID. I suggest
`DecisionTreeClassificationModel (uid=$uid) of depth $depth with $numNodes
nodes`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
