Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/8132#discussion_r36957077
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PartitioningUtils.scala
---
@@ -270,6 +271,18 @@ private[sql] object PartitioningUtils {
private val upCastingOrder: Seq[DataType] =
Seq(NullType, IntegerType, LongType, FloatType, DoubleType, StringType)
+ def checkPartitionColumnOfValidDataType(
+ schema: StructType,
+ partitionColumns: Array[String]): Unit = {
+
+ ResolvedDataSource.partitionColumnsSchema(schema,
partitionColumns).foreach { field =>
+ field.dataType match {
+ case _: AtomicType | NullType => // OK
--- End diff --
@rxin Is it legal to have a column of `NullType`? I think it's mostly used
for internal type checking purposes and shouldn't appear in user space code?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
