Github user markgrover commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8007#discussion_r37101551
  
    --- Diff: 
yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala ---
    @@ -207,6 +211,17 @@ private[yarn] class YarnAllocator(
       }
     
       /**
    +   * Gets the executor loss reason for a disconnected executor.
    +   * Note that this method is expected to be called exactly once per 
executor ID.
    +   */
    +  def getExecutorLossReason(executorId: String): ExecutorLossReason = 
synchronized {
    +    allocateResources()
    --- End diff --
    
    This is likely very noob of me so please pardon me, if so. Why do we need a 
call to allocateResources() here? I get processCompletedContainers() is 
important for you so the reasons get populated but wouldn't that have happened 
when the container in question was originally allocated by 
ApplicationMaster::launchReporterThread() (and subsequently killed).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to