Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/1058#discussion_r13726015
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -750,19 +736,16 @@ private[spark] class BlockManager(
bytesAfterPut = dataSerialize(blockId, valuesAfterPut)
}
replicate(blockId, bytesAfterPut, level)
- logDebug("Put block " + blockId + " remotely took " +
- Utils.getUsedTimeMs(remoteStartTime))
- }
+ logDebug(s"Put block $blockId remotely took
${Utils.getUsedTimeMs(remoteStartTime)}")
--- End diff --
Minor - but I think it's a bit nicer to assign expressions like this to a
variable rather than having function calls interpolated in strings.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
