Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/8216#discussion_r37136449
--- Diff: core/src/main/scala/org/apache/spark/scheduler/JobWaiter.scala ---
@@ -17,6 +17,10 @@
package org.apache.spark.scheduler
+import sun.misc.{Signal, SignalHandler}
--- End diff --
This dependency can cause both Runtime and Compile time problems, if the
used JVM/compiler does not provide these classes. Does this work with other JVM
implementations, such as OpenJDK and IBM JDK?
I am in favor of this functionality, but I think we should be very careful
using platform specific code. Luckily this is not the first time people had to
solve this problem. JLine solves this in the following way:
https://github.com/jline/jline2/blob/master/src/main/java/jline/console/ConsoleReader.java#L257-L284
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
