Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1058#discussion_r13729334
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -329,15 +326,16 @@ private[spark] class BlockManager(
* never deletes (recent) items.
*/
def getLocalFromDisk(blockId: BlockId, serializer: Serializer):
Option[Iterator[Any]] = {
- diskStore.getValues(blockId, serializer).orElse(
- sys.error("Block " + blockId + " not found on disk, though it should
be"))
+ diskStore.getValues(blockId, serializer).orElse {
+ throw new SparkException(s"Block $blockId not found on disk, though
it should be")
--- End diff --
I looked at the code more closely, and it looks like we do this all over
the place. I think the point is that this is a `getLocal*` method, so it's
supposed to exist on disk. I think it might actually be good to keep this
exception.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
