Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/997#discussion_r13731544
--- Diff:
core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala ---
@@ -272,6 +287,24 @@ class SparkSubmitSuite extends FunSuite with
ShouldMatchers {
new File(sparkHome),
Map("SPARK_TESTING" -> "1", "SPARK_HOME" -> sparkHome))
}
+
+ def forConfDir(defaults: Map[String, String]) (f: String => Unit) = {
+ val tmpDir = new File("TMP_SPARK_CONF_DIR")
--- End diff --
Just a clarification: I see you're deleting the directory below, so
BeforeAndAfter does not apply here. But still I'd prefer to use
Files.createTempDir() instead of a hardcoded name. Just for paranoia.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
