Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/8033#issuecomment-131945578
@zhzhan could I get your eyes on this change? My change is causing
`OrcQuerySuite` to fail, and I'm not yet clear why. I see you created much of
this test. I'm looking for clues before I start taking apart my change piece by
piece.
The failure is that the `Map`s which are expected to map `1 -> 1`, `2 ->
2`, etc. don't match up. My change is replacing implicit Scala <-> Java
conversion with more explicit conversion. It's obviously either a typo, or some
behavior difference, introduced in the process that broke the test, which
passes normally. If anything jumps out at you as a good place to look let me
know.
```
[info] OrcQuerySuite:
[info] - Read/write All Types (1 second, 895 milliseconds)
[info] - Read/write binary data (374 milliseconds)
10:22:00.729 WARN org.apache.spark.scheduler.TaskSetManager: Stage 10988
contains a task of very large size (100 KB). The maximum recommended task size
is 100 KB.
[info] - Read/write all types with non-primitive type *** FAILED *** (6
seconds, 266 milliseconds)
[info] Results do not match for query:
...
[info] ![10,10,10,10.0,10.0,10,10,true,WrappedArray(0, 1, 2, 3, 4, 5, 6,
7, 8, 9),WrappedArray(0, null, null, 3, null, null, 6, null, null, 9),Map(0 ->
0, 5 -> 5, 1 -> 1, 6 -> 6, 9 -> 9, 2 -> 2, 7 -> 7, 3 -> 3, 8 -> 8, 4 ->
4),Map(0 -> 0, 5 -> 5, 10 -> null, 1 -> 1, 6 -> 6, 9 -> 9, 2 -> 2, 7 -> 7, 3 ->
3, 8 -> 8, 4 -> 4),[WrappedArray(0, 1, 2, 3, 4, 5, 6, 7, 8, 9),[10,10]]]
[10,10,10,10.0,10.0,10,10,true,WrappedArray(0, 1, 2, 3, 4, 5, 6, 7,
8, 9),WrappedArray(0, null, null, 3, null, null, 6, null, null, 9),Map(0 -> 0,
5 -> 1, 1 -> 2, 6 -> 3, 9 -> 4, 2 -> 5, 7 -> 6, 3 -> 7, 8 -> 8, 4 -> 9),Map(0
-> 0, 5 -> 1, 10 -> 2, 1 -> 3, 6 -> 4, 9 -> 5, 2 -> 6, 7 -> 7, 3 -> 8, 8 -> 9,
4 -> null),[WrappedArray(0, 1, 2, 3, 4, 5, 6, 7, 8, 9),[10,10]]]
...
```--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at [email protected] or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
