Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/8264#issuecomment-132064057
Thanks @yu-iskw -- Change looks pretty good to me and the test cases are
especially good. Thanks for adding that.
Lets see if @rxin or @davies have any thoughts on the minor Scala style
thing I mentioned inline
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
