GitHub user dorx opened a pull request:
https://github.com/apache/spark/pull/1073
[SPARK-1970] Update unit test in XORShiftRandomSuite to use ChiSquareTest
from commons-math3
Updating the chisquare unit test in XORShiftRandomSuite to use the
ChiSquareTest in commons-math3 instead of hardcoding the chisquare statistic
for the desired confidence interval.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dorx/spark math3Unit
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/1073.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1073
----
commit 14419775202e6eef1f0e1f0c74c7be9030aca73d
Author: Doris Xin <[email protected]>
Date: 2014-05-29T22:22:14Z
SPARK-1939 Refactor takeSample method in RDD to use ScaSRS
commit ffea61a67d228edb476d29ca13a84bb3f9a22887
Author: Doris Xin <[email protected]>
Date: 2014-05-30T00:55:54Z
SPARK-1939: Refactor takeSample method in RDD
Reviewer comments addressed:
- commons-math3 is now a test-only dependency. bumped up to v3.3
- comments added to explain what computeFraction is doing
- fixed the unit for computeFraction to use BinomialDitro for without
replacement sampling
- stylistic fixes
commit 8f84f193e6ebc6f77fd31f56cd29b517a150e6b2
Author: Doris Xin <[email protected]>
Date: 2014-05-30T02:19:56Z
[SPARK-1970] unit test in XORShiftRandomSuite
Since we're adding commons-math3 as a test dependency to spark core,
updating the test for randomness in XORShiftRandomSuite to use an
actual chi square test as opposed to hardcoding everything.
commit c19948ffb726aec3e29424646afc5af01230eda3
Author: Doris Xin <[email protected]>
Date: 2014-05-30T02:26:55Z
Merge branch 'master' into math3Unit
commit 99541434bb7081f8aadb893e4b0d73407bf3ad71
Author: Doris Xin <[email protected]>
Date: 2014-06-13T03:02:49Z
merge master
commit da0e8919afb5f3d335840a3dcae398ecf6921b27
Author: Doris Xin <[email protected]>
Date: 2014-06-13T03:10:38Z
remove math3 from common pom
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
