Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/981#discussion_r13738740
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/Stage.scala ---
    @@ -100,7 +101,8 @@ private[spark] class Stage(
         id
       }
     
    -  val name = callSite.getOrElse(rdd.getCreationSite)
    +  val name = callSite.map(_.short).getOrElse(rdd.getCreationSite)
    --- End diff --
    
    Instead of adding `name` and `details` can we just have `callSite` be a 
val? We have a concept of `name` for an RDD an it's a little different than 
this (e.g. it can be overridden by users). At present this really is just 
exactly equal to a call site. My proposal makes more sense if `callSite` is not 
an option, which I'm also proposing (see later comments).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to