GitHub user feynmanliang opened a pull request:
https://github.com/apache/spark/pull/8290
[SPARK-10097] Adds `shouldMaximize` flag to `ml.tuning.Evaluator`
Previously, users of evaluator (`CrossValidator` and
`TrainValidationSplit`) would only maximize the metric in evaluator, leading to
a hacky solution which negated metrics to be minimized and caused erroneous
negative values to be reported to the user.
This PR adds a `shouldMaximize` attribute to the `Evaluator` base class,
instructing users of `Evaluator` on whether the chosen metric should be
maximized or minimized.
CC @jkbradley
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/feynmanliang/spark SPARK-10097
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/8290.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #8290
----
commit a84c85bd3a6bb75057daa8908c20941b49b8067c
Author: Joseph K. Bradley <[email protected]>
Date: 2015-08-18T22:22:42Z
a bit done
commit 7b00d2e8527b27953090a459c331744aafb2969e
Author: Feynman Liang <[email protected]>
Date: 2015-08-18T22:58:53Z
Completes the fix
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
