Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/969#discussion_r13749661
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -131,6 +132,13 @@ private[spark] class SparkSubmitArguments(args:
Seq[String]) {
if (name == null && primaryResource != null) {
name = Utils.stripDirectory(primaryResource)
}
+
+ if (master.startsWith("yarn")) {
--- End diff --
seems a bit odd to be putting yarn specific configs in here. This also
won't allow it to work if you are using spark-class directly. Which actually
shouldn't be required but it might be nice to be able to use the configs if you
are using java directly instead of the spark-submit script (if you are using
oozie for instance). Based on all that I would prefer to see this moved into
the yarn Client. Sorry if I am late on my comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
