Github user rahulsinghaliitd commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1076#discussion_r13750359
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala 
---
    @@ -154,6 +154,8 @@ private[spark] class Master(
       }
     
       override def postStop() {
    +    masterMetricsSystem.report()
    +    applicationMetricsSystem.report()
    --- End diff --
    
    FYI:
    
    Although I have added reports to be triggered here and in the Worker before 
shutdown, I am not sure how a graceful shutdown of Master and Worker is 
triggered (because the stop-all.sh scripts kills these services and this code 
is never executed). 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to