Github user markgrover commented on a diff in the pull request:
https://github.com/apache/spark/pull/7739#discussion_r37456912
--- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
@@ -479,6 +484,23 @@ class SparkConf(loadDefaults: Boolean) extends
Cloneable with Logging {
getAll.sorted.map{case (k, v) => k + "=" + v}.mkString("\n")
}
+ def getDriverExtraClassPath() : Option[String] = {
+ // Concatenate common and driver classpath in that order
+ val commonExtraClassPath = getOption("spark.common.extraClassPath")
+ val driverExtraClassPath = getOption("spark.driver.extraClassPath")
+ Option((commonExtraClassPath ++
driverExtraClassPath).mkString(File.pathSeparator)).filter(_
--- End diff --
Actually, it can be null, right? If neither spark.common.extraClassPath nor
spark.driver.extraClassPath are set, I'd like this function to return None so I
am not changing the original semantics of anybody calling this function. And,
if so, casting as option is right thing, no?
If there is a more legible way of expressing this, I am totally open to it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
