Github user yjshen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8274#discussion_r37487469
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala
 ---
    @@ -582,6 +582,109 @@ case class StringLocate(substr: Expression, str: 
Expression, start: Expression)
         }
       }
     
    +  override def genCode(ctx: CodeGenContext, ev: GeneratedExpressionCode): 
String = {
    +    if (start.foldable) {
    --- End diff --
    
    I was following 
https://github.com/apache/spark/pull/7779#discussion_r35945742, if it's not 
required, I think 7779 is fine.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to