Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8313#discussion_r37513118
--- Diff: python/pyspark/ml/feature.py ---
@@ -775,7 +775,7 @@ def mean(self):
@inherit_doc
-class StringIndexer(JavaEstimator, HasInputCol, HasOutputCol):
+class StringIndexer(JavaEstimator, HasInputCol, HasOutputCol,
HasHandleInvalid):
--- End diff --
```handleInvalid``` is common properties and other
```Transformer/Estimator```s may use it in future, so we need to make it shared
param. Another reason is that we want to make Python consistency with Scala,
and
[```handleInvalid```](https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/ml/param/shared/sharedParams.scala#L255)
in Scala is shared param.
@jkbradley
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
