Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8308#discussion_r37556418
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -178,35 +185,41 @@ class DAGScheduler(
}
/**
- * Update metrics for in-progress tasks and let the master know that the
BlockManager is still
- * alive. Return true if the driver knows about the given block manager.
Otherwise, return false,
- * indicating that the block manager should re-register.
+ * Called by the TaskScheduler implementation when an executor fails.
*/
- def executorHeartbeatReceived(
- execId: String,
- taskMetrics: Array[(Long, Int, Int, TaskMetrics)], // (taskId,
stageId, stateAttempt, metrics)
- blockManagerId: BlockManagerId): Boolean = {
- listenerBus.post(SparkListenerExecutorMetricsUpdate(execId,
taskMetrics))
- blockManagerMaster.driverEndpoint.askWithRetry[Boolean](
- BlockManagerHeartbeat(blockManagerId), 600 seconds)
- }
-
- // Called by TaskScheduler when an executor fails.
def executorLost(execId: String): Unit = {
eventProcessLoop.post(ExecutorLost(execId))
}
- // Called by TaskScheduler when a host is added
+ /**
+ * Called by the TaskScheduler implementation when a host is added.
+ */
def executorAdded(execId: String, host: String): Unit = {
eventProcessLoop.post(ExecutorAdded(execId, host))
}
- // Called by TaskScheduler to cancel an entire TaskSet due to either
repeated failures or
- // cancellation of the job itself.
+ /**
+ * Called by the TaskSetManager to cancel an entire TaskSet due to either
+ * repeated failures or cancellation of the job itself.
+ */
def taskSetFailed(taskSet: TaskSet, reason: String): Unit = {
eventProcessLoop.post(TaskSetFailed(taskSet, reason))
}
+ /**
--- End diff --
This move might be reasonable but I don't know if it is worth the change of
merge conflict
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
