Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/8341#discussion_r37595534
--- Diff:
sql/core/src/test/gen-java/org/apache/spark/sql/execution/datasources/parquet/test/avro/AvroArrayOfArray.java
---
@@ -0,0 +1,142 @@
+/**
+ * Autogenerated by Avro
--- End diff --
When adding the first set of Parquet Avro/Thrift/Hive compatibility suites,
I considered building these files on demand, but that complicates the build
process. Especially, it requires developers and Jenkins to install Thrift
binary executable to for code generation (or is there any way to avoid this?).
Besides that, it's super tricky to compile the version of the Thrift binary
executable Parquet uses under Mac because Mac lacks some C++ header files (I
always compile parquet-thrift tests under a Ubuntu VM). That's why I decided to
include the generated Java files. In this way, only developers who update these
test suites need to install these extra dependencies.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
