Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8356#discussion_r37618495
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/sources/interfaces.scala ---
    @@ -278,44 +301,6 @@ trait PrunedFilteredScan {
     }
     
     /**
    - * ::DeveloperApi::
    - * A BaseRelation that can be used to insert data into it through the 
insert method.
    - * If overwrite in insert method is true, the old data in the relation 
should be overwritten with
    - * the new data. If overwrite in insert method is false, the new data 
should be appended.
    - *
    - * InsertableRelation has the following three assumptions.
    - * 1. It assumes that the data (Rows in the DataFrame) provided to the 
insert method
    - * exactly matches the ordinal of fields in the schema of the BaseRelation.
    - * 2. It assumes that the schema of this relation will not be changed.
    - * Even if the insert method updates the schema (e.g. a relation of JSON 
or Parquet data may have a
    - * schema update after an insert operation), the new schema will not be 
used.
    - * 3. It assumes that fields of the data provided in the insert method are 
nullable.
    - * If a data source needs to check the actual nullability of a field, it 
needs to do it in the
    - * insert method.
    - *
    - * @since 1.3.0
    - */
    -@DeveloperApi
    -trait InsertableRelation {
    -  def insert(data: DataFrame, overwrite: Boolean): Unit
    -}
    --- End diff --
    
    I moved it to the relation section.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to