Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/8362#issuecomment-133544919
This made my day. The approach is super cool.
Couple suggestions:
1. Can we use HyperLogLogPlus? It's also in streamlib:
https://github.com/addthis/stream-lib/blob/master/src/main/java/com/clearspring/analytics/stream/cardinality/HyperLogLogPlus.java
2. Can we write this in a way to make it more unit testable?
Beyond this, would be cool to have count-min sketch too! (future work)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
