Github user selvinsource commented on the pull request:
https://github.com/apache/spark/pull/7842#issuecomment-133677161
As overall comment, to add to my specific comments above, I would say we
should create the field names once (possibly in the data dictionary as data
fields) and re-use these when creating mining fields or predicates. By doing so
we ensure we are not creating field names that are not in the dictionary (due
to potential bugs in the code for example).
In parallel I am updating my pmml validator project so that it validates
the models exported from the Decision Tree exporter for both classification and
regression. I will let you know when I have the results.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
