Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/8400#discussion_r37828250
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -37,7 +37,8 @@ object DateTimeUtils {
type SQLTimestamp = Long
// see
http://stackoverflow.com/questions/466321/convert-unix-timestamp-to-julian
- final val JULIAN_DAY_OF_EPOCH = 2440587 // and .5
+ // it's 2440587.5, rounding up to compatible with Hive
+ final val JULIAN_DAY_OF_EPOCH = 2440588 //
--- End diff --
Nit: removing the trailing `//`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
