Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/8417#discussion_r37865133
--- Diff:
streaming/src/test/scala/org/apache/spark/streaming/receiver/BlockGeneratorSuite.scala
---
@@ -184,9 +184,10 @@ class BlockGeneratorSuite extends SparkFunSuite with
BeforeAndAfter {
// Verify that the final data is present in the final generated block
and
// pushed before complete stop
assert(blockGenerator.isStopped() === false) // generator has not
stopped yet
- clock.advance(blockIntervalMs) // force block generation
--- End diff --
There is a race condition here. If `updateCurrentBuffer` runs before
`blockIntervalTimer.stop(interruptTimer = false)`, this test will fail because
RecurringTimer is blocking in this line:
https://github.com/apache/spark/blob/69c9c177160e32a2fbc9b36ecc52156077fca6fc/streaming/src/main/scala/org/apache/spark/streaming/util/RecurringTimer.scala#L96
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
