Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/8383#discussion_r37883244
--- Diff:
unsafe/src/main/java/org/apache/spark/unsafe/bitset/BitSetMethods.java ---
@@ -68,6 +68,19 @@ public static boolean isSet(Object baseObject, long
baseOffset, int index) {
}
/**
+ * Returns {@code true} if all bits are set.
+ */
+ public static boolean allSet(Object baseObject, long baseOffset, long
bitSetWidthInWords) {
+ long addr = baseOffset;
+ for (int i = 0; i < bitSetWidthInWords; i++, addr += WORD_SIZE) {
+ if (Platform.getLong(baseObject, addr) == 0) {
--- End diff --
This confuses me. It seems that you are checking that all bits in a given
word are not set (0), instead of checking that any one the bits is not set. Am
I missing something?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
