GitHub user skyluc opened a pull request:
https://github.com/apache/spark/pull/8433
[SPARK-10227] fatal warnings with sbt on Scala 2.11
The bulk of the changes are on `@transient` annotation on class parameter.
Often the compiler doesn't generate a field for this parameters, so the the
transient annotation would be unnecessary.
But if the class parameter are used in methods, then fields are created. So
it is safer to keep the annotations.
The remainder are some potential bugs, and deprecated syntax.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/skyluc/spark issue/sbt-2.11
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/8433.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #8433
----
commit 09a53050d60bfb8b3435ab4cf28a4489c7f08daf
Author: Luc Bourlier <[email protected]>
Date: 2015-08-25T19:39:04Z
Fixes Scala 2.11 warnings on @transient
Made the @transient more precise, to tell it to apply to the generated
fields.
Kept the annotation, even if a lot of them are no-op, as the fields are not
generated for these
class paramaters. But it can limit bugs down the line.
Removed the anotations on the abstract element. They just don't make sense.
commit 9b2b17616fea3579c2d66f213154fd5bf9a97845
Author: Luc Bourlier <[email protected]>
Date: 2015-08-25T19:47:34Z
Fixes Scala 2.11 warnings, try without a catch
commit 52cf76d56759cfb4a596a63373da419c0eb6fed6
Author: Luc Bourlier <[email protected]>
Date: 2015-08-25T19:48:45Z
Fixes Scala 2.11 warnings, infered (): Unit values
commit 13f41b0332ac6a26277210057bccdb89554ac885
Author: Luc Bourlier <[email protected]>
Date: 2015-08-25T19:49:32Z
Fixed Scala 2.11 warnings, erased types in match
commit 67016fb2027c2896aa3ee07b19cc4162e0c78bc7
Author: Luc Bourlier <[email protected]>
Date: 2015-08-25T19:50:25Z
Fixes Scala 2.11 warnings, deprecated octal notation
commit 1257e1f5d2a990f2e6e82bec7ca90fc278e9d991
Author: Luc Bourlier <[email protected]>
Date: 2015-08-25T19:51:40Z
Fixes Scala 2.11 warnings, use of postfix notation
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
