Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1086#discussion_r13793040
  
    --- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala ---
    @@ -1052,11 +1052,11 @@ abstract class RDD[T: ClassTag](
        * Returns the top K (largest) elements from this RDD as defined by the 
specified
        * implicit Ordering[T]. This does the opposite of [[takeOrdered]]. For 
example:
        * {{{
    -   *   sc.parallelize([10, 4, 2, 12, 3]).top(1)
    -   *   // returns [12]
    +   *   sc.parallelize(Array(10, 4, 2, 12, 3)).top(1)
    --- End diff --
    
    Extremely minor - but it would be better to use `Seq` instead of `Array` in 
these examples. Otherwise people might think they need to pass an `Array` to 
`parallelize` whereas in fact it accepts more widely than that. I looked and we 
actually use `Array` in one other place in the current codebase, we should 
separately probably change that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to