Github user rotationsymmetry commented on a diff in the pull request:
https://github.com/apache/spark/pull/7884#discussion_r38033569
--- Diff: project/MimaExcludes.scala ---
@@ -60,6 +60,10 @@ object MimaExcludes {
"org.apache.spark.ml.regression.LeastSquaresCostFun.this"),
ProblemFilters.exclude[MissingMethodProblem](
"org.apache.spark.ml.classification.LogisticCostFun.this"),
+ ProblemFilters.exclude[MissingMethodProblem](
--- End diff --
I am also learning so this is only my two cents: the migration manager
(MiMa) will check for binary incompatibility from previous versions. In this
PR, the `add` and `merge` method of `LogisticAggregator` is revised to take
different argument type than before. A library written for previous versions of
`LogisticAggregator` will not be able to link to the new version. MiMa will
detect this binary incompatibility.
We stop MiMa from complaining by excluding these methods from the
compatibility checking.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
