Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/8118#discussion_r38171487
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StopWordsRemover.scala ---
@@ -29,14 +29,14 @@ import org.apache.spark.sql.types.{ArrayType,
StringType, StructField, StructTyp
/**
* stop words list
*/
-private object StopWords {
+protected[spark] object StopWords {
/**
* Use the same default stopwords list as scikit-learn.
* The original list can be found from "Glasgow Information Retrieval
Group"
* [[http://ir.dcs.gla.ac.uk/resources/linguistic_utils/stop_words]]
*/
- val EnglishStopWords = Array( "a", "about", "above", "across", "after",
"afterwards", "again",
+ val ENGLISH_STOP_WORDS = Array( "a", "about", "above", "across",
"after", "afterwards", "again",
--- End diff --
minor: Since the object is already `StopWords`, would `English` be
sufficient? We didn't use `ENGLISH_STOP_WORDS` because it is a mutable array.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
