Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8484#discussion_r38177238
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala
 ---
    @@ -323,6 +309,7 @@ object GenerateUnsafeProjection extends 
CodeGenerator[Seq[Expression], UnsafePro
     
               int $cursor = $fixedSize;
               for (int $index = 0; $index < $numElements; $index++) {
    +            ${convertedElement.code}
    --- End diff --
    
    Thanks for reviewing. I've updated this patch to use the dynamic buffer 
approach. I think it should be better now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to