Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8518#discussion_r38265243
--- Diff: docs/ml-guide.md ---
@@ -971,10 +907,9 @@ ParamMap[] paramGrid = new ParamGridBuilder()
TrainValidationSplit trainValidationSplit = new TrainValidationSplit()
.setEstimator(lr)
.setEvaluator(new RegressionEvaluator())
- .setEstimatorParamMaps(paramGrid);
-
-// 80% of the data will be used for training and the remaining 20% for
validation.
-trainValidationSplit.setTrainRatio(0.8);
+ .setEstimatorParamMaps(paramGrid)
+ // 80% of the data will be used for training and the remaining 20% for
validation.
--- End diff --
nit: having a comment break a builder looks a bit weird, but this is also
too long to comment inline.... perhaps we could document everything that's
happening on L906?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
