Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8494#discussion_r38265509
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala
 ---
    @@ -155,6 +155,8 @@ case class Alias(child: Expression, name: String)(
             explicitMetadata == a.explicitMetadata
         case _ => false
       }
    +
    +  def cleanExprId(): Alias = Alias(child, name)(ExprId(-1), qualifiers)
    --- End diff --
    
    Why does this have `()`?  It also needs scala doc.  However, since its only 
ever used once, I'd consider just inlining it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to