Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/8521#discussion_r38268166
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -858,7 +858,7 @@ class SparkContext(config: SparkConf) extends Logging
with ExecutorAllocationCli
// Use setInputPaths so that wholeTextFiles aligns with
hadoopFile/textFile in taking
// comma separated files as input. (see SPARK-7155)
NewFileInputFormat.setInputPaths(job, path)
- val updateConf = job.getConfiguration
+ val updateConf =
SparkHadoopUtil.get.getConfigurationFromJobContext(job)
--- End diff --
@JoshRosen I didn't change `job.getConfiguration` last time because they
uses `org.apache.hadoop.mapreduce.Job` whose `getConfiguration` is compatible.
However, +1 for this change since it is good for maintenance.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
