Github user sethah commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-136408857
Just a thought I had while looking over this PR: It makes more sense to me
to refer to the sample weights as `sampleWeight` instead of `weight`, since the
regression coefficient vector is called `weights` regularly throughout the
code. This was causing me some confusion and it is a bit clearer to call it
`sampleWeight`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
