Github user feynmanliang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8457#discussion_r38367379
  
    --- Diff: python/pyspark/mllib/classification.py ---
    @@ -600,12 +604,15 @@ class 
StreamingLogisticRegressionWithSGD(StreamingLinearAlgorithm):
         :param miniBatchFraction: Fraction of data on which SGD is run for each
                                   iteration.
         :param regParam: L2 Regularization parameter.
    +    :param convergenceTol: A condition which decides iteration termination.
    --- End diff --
    
    Not part of this PR, but do you mind documenting default values?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to