Github user feynmanliang commented on the pull request:
https://github.com/apache/spark/pull/8507#issuecomment-136530334
Changes look good, only comments are about being consistent. Specifically:
* Use `Seq` for specifying the schema `StructType`
* Make the `schema` a private class val rather than inside the `save` method
* Line breaks in between methodsd
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
