Github user rotationsymmetry commented on a diff in the pull request:
https://github.com/apache/spark/pull/8022#discussion_r38386646
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingLinearRegressionWithSGD.scala
---
@@ -47,6 +52,7 @@ class StreamingLinearRegressionWithSGD private[mllib] (
private var numIterations: Int,
private var miniBatchFraction: Double)
extends StreamingLinearAlgorithm[LinearRegressionModel,
LinearRegressionWithSGD]
+ with StreamingDecaySetter[StreamingLinearRegressionWithSGD]
--- End diff --
Thanks for the suggestions. I think `A` captures the class of non-streaming
algorithm. For example,
``` scala
class StreamingLinearRegressionWithSGD
extends StreamingLinearAlgorithm[LinearRegressionModel,
LinearRegressionWithSGD]
```
The concrete subtype that `A` capture is `LinearRegressionWithSGD`.
However, the fluent setter needs to return `StreamingLinearRegressionWithSGD`,
though.
What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
