Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8218#discussion_r38579943
--- Diff:
network/common/src/main/java/org/apache/spark/network/server/OneForOneStreamManager.java
---
@@ -109,15 +111,34 @@ public void connectionTerminated(Channel channel) {
}
}
+ @Override
+ public void checkAuthorization(TransportClient client, long streamId) {
+ if (client.getClientId() != null) {
--- End diff --
I'm confused about this: since `getClientId` returns null if the client did
not enable `spark.authenticate`, does that mean any application that did not
enable SASL can read my shuffle files?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
