Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4887#discussion_r38583096
--- Diff: core/src/main/scala/org/apache/spark/CacheManager.scala ---
@@ -152,6 +152,9 @@ private[spark] class CacheManager(blockManager:
BlockManager) extends Logging {
*/
updatedBlocks ++=
blockManager.putIterator(key, values, level, tellMaster = true,
effectiveStorageLevel)
+ if (level.useMemory) {
+ blockManager.memoryStore.releasePendingUnrollMemoryForThisThread()
+ }
--- End diff --
Then I would add a comment for this block down there:
```
// After putting this on disk, we no longer need the Array that stored the
partial values, so we
// should release the unroll memory occupied in the process for other tasks
(SPARK-6157).
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
