Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7884#discussion_r38586801
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -803,13 +829,17 @@ private class LogisticAggregator(
this
}
- def count: Long = totalCnt
-
- def loss: Double = lossSum / totalCnt
+ def loss: Double = {
+ require(weightSum >= 1.0, s"The effective number of samples should be
" +
+ s"greater than or equal to 1.0, but $weightSum.")
+ lossSum / weightSum
+ }
def gradient: Vector = {
+ require(weightSum >= 1.0, s"The effective number of samples should be
" +
--- End diff --
ditto
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
