Github user mengxr commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8567#discussion_r38589547
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
    @@ -501,7 +501,13 @@ trait Params extends Identifiable with Serializable {
        */
       final def getDefault[T](param: Param[T]): Option[T] = {
         shouldOwn(param)
    -    defaultParamMap.get(param)
    +    try {
    +      defaultParamMap.get(param)
    +    } catch {
    +      case e: NoSuchElementException =>
    --- End diff --
    
    We don't have performance issues here. So code readability is more 
important, e.g.,
    
    ~~~scala
    defaultParamMap.getOrElse(param, 
      throw new NoSuchElementException(s"No default value for ${param.name} in 
${this.getClass}.")
    ~~~


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to