Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/270#discussion_r13874310
  
    --- Diff: ec2/spark_ec2.py ---
    @@ -691,12 +691,18 @@ def real_main():
         setup_cluster(conn, master_nodes, slave_nodes, opts, True)
     
       elif action == "destroy":
    -    response = raw_input("Are you sure you want to destroy the cluster " +
    -        cluster_name + "?\nALL DATA ON ALL NODES WILL BE LOST!!\n" +
    +    (master_nodes, slave_nodes) = get_existing_cluster(
    +        conn, opts, cluster_name, die_on_error=False)
    +
    +    print "Are you sure you want to destroy the cluster " + \
    --- End diff --
    
    Very minor - but it might be slightly nicer to write this using string 
interpolation and also just using two different print statements instead of 
putting a newline directly in there (since you'll get python's system-dependent 
line delimiter).
    ```
    print "Are you sure you want to destroy the cluster %s?" % cluster_name
    print "The following instances will be terminated:"
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to