Github user davies commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8578#discussion_r38601580
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/columnar/InMemoryColumnarQuerySuite.scala
 ---
    @@ -191,4 +191,13 @@ class InMemoryColumnarQuerySuite extends QueryTest 
with SharedSQLContext {
           ctx.table("InMemoryCache_different_data_types").collect())
         ctx.dropTempTable("InMemoryCache_different_data_types")
       }
    +
    +  test("SPARK-10422: String column in InMemoryColumnarCache needs to 
override clone method") {
    +    val df =
    +      ctx.range(1, 30000).selectExpr("id % 500 as id").rdd.map(id => 
Tuple1(s"str_$id")).toDF("i")
    +    val cached = df.cache()
    +    // count triggers the caching action. It should not throw.
    +    cached.count()
    --- End diff --
    
    Should we check the results?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to