Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8007#discussion_r38605520
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/cluster/YarnSchedulerBackend.scala
 ---
    @@ -91,6 +94,36 @@ private[spark] abstract class YarnSchedulerBackend(
       }
     
       /**
    +   * Override the DriverEndpoint to add extra logic for the case when an 
executor is disconnected.
    --- End diff --
    
    Can you make it explicit who this endpoint talks to? Otherwise it's kinda 
confusing to see two endpoints in the same class on the driver.
    ```
    An [[RpcEndpoint]] that communicates with the executors and used internally 
within the driver.
    Here we override the DriverEndpoint to ...
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to