Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/931#discussion_r13878082
--- Diff:
core/src/main/scala/org/apache/spark/util/collection/ExternalAppendOnlyMap.scala
---
@@ -104,7 +106,8 @@ class ExternalAppendOnlyMap[K, V, C](
private var _diskBytesSpilled = 0L
private val fileBufferSize =
sparkConf.getInt("spark.shuffle.file.buffer.kb", 100) * 1024
- private val comparator = new KCComparator[K, C]
+ protected val comparator = if (customizedComparator == null) new
KCComparator[K, C]
+ else customizedComparator
--- End diff --
nit: I would move the whole `if` to the next line:
```
protected val comparator =
if (...) ... else ...
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
